-
Notifications
You must be signed in to change notification settings - Fork 12
fix: proper LICENSE metadata for package #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can see it here: https://github.com/ansys/pyansys/actions/runs/16913194539/job/47920201265?pr=1035#step:2:980 This requires an immediate fix and patch release @moe-ad @PProfizi |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 52 52
Lines 5214 5214
=======================================
Hits 4439 4439
Misses 775 775 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @RobPasMue! @PProfizi is currently OOO and I am not certain about the correct procedure for a pydpf-post release.
I can see that releases are performed from branches, so might be as simple as just creating a patch release branch and triggering the ci_release
workflow. i could give that a try or maybe we should wait till Paul returns to avoid breaking things.
We can wait for now if you prefer - but please let me know once there is a new release. Thanks @moe-ad |
Noted. Thanks once again @RobPasMue. |
Hi both, just so you know this was changed to mimick the behavior in pydpf-core, and to try and fix the error at release here. What was done in the meantime is to pin the version of twine used, but at some point this will need a real fix. |
@RobPasMue |
Most probably because of the build-system that you are using. PyDPF Core uses setuptools and PyDPF Post uses flit |
Currently, the license is not showing up properly for ansys-dpf-post. This is caused by the way in which the license is referred in the pyproject.toml file. It should be done in this way moving forward