Skip to content

fix: proper LICENSE metadata for package - #893

Merged
PProfizi merged 1 commit into
mainfrom
fix/license
Aug 18, 2025
Merged

PProfizi merged 1 commit into
mainfrom
fix/license

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Currently, the license is not showing up properly for ansys-dpf-post. This is caused by the way in which the license is referred in the pyproject.toml file. It should be done in this way moving forward

@RobPasMue
RobPasMue requested review from PProfizi and moe-ad August 13, 2025 07:46
@RobPasMue

Copy link
Copy Markdown
Member Author

You can see it here: https://github.com/ansys/pyansys/actions/runs/16913194539/job/47920201265?pr=1035#step:2:980

This requires an immediate fix and patch release @moe-ad @PProfizi

@codecov

codecov Bot commented Aug 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (c9baf6f) to head (20b2cab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files          52       52           
  Lines        5214     5214           
=======================================
  Hits         4439     4439           
  Misses        775      775           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moe-ad moe-ad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @RobPasMue! @PProfizi is currently OOO and I am not certain about the correct procedure for a pydpf-post release.

I can see that releases are performed from branches, so might be as simple as just creating a patch release branch and triggering the ci_release workflow. i could give that a try or maybe we should wait till Paul returns to avoid breaking things.

@RobPasMue

Copy link
Copy Markdown
Member Author

We can wait for now if you prefer - but please let me know once there is a new release. Thanks @moe-ad

@moe-ad

moe-ad commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Noted. Thanks once again @RobPasMue.

@PProfizi

Copy link
Copy Markdown
Contributor

Hi both, just so you know this was changed to mimick the behavior in pydpf-core, and to try and fix the error at release here. What was done in the meantime is to pin the version of twine used, but at some point this will need a real fix.
In the meantime I'll do a patch release.

@PProfizi
PProfizi merged commit 422e011 into main Aug 18, 2025
32 of 33 checks passed
@PProfizi
PProfizi deleted the fix/license branch August 18, 2025 07:40
@PProfizi PProfizi added the maintenance Repository structure maintenance label Aug 18, 2025
@PProfizi

Copy link
Copy Markdown
Contributor

@RobPasMue
this is what we have in ansys-dpf-core though, why would it not work here?

@RobPasMue

Copy link
Copy Markdown
Member Author

Most probably because of the build-system that you are using. PyDPF Core uses setuptools and PyDPF Post uses flit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Repository structure maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants